Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git lfs install instructions #298

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Add git lfs install instructions #298

merged 2 commits into from
Nov 6, 2023

Conversation

mkuchnik
Copy link
Contributor

@mkuchnik mkuchnik commented Nov 3, 2023

There seems to be implicit usage of git lfs, which is potentially surprising and can cause flaky tests for unsuspecting users. The patch adds a check and install instructions.

@mkuchnik mkuchnik requested a review from a team as a code owner November 3, 2023 19:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

marcenacp
marcenacp approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@marcenacp marcenacp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mkuchnik mkuchnik merged commit 342a546 into mlcommons:main Nov 6, 2023
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcenacp marcenacp marcenacp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkuchnik @marcenacp